Skip to content

Fix get next line #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdj0c merged 2 commits into from
Apr 20, 2026
Merged

Fix get next line #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b948a3e
selection: fix off-by-one error in get_next_line()
Apr 20, 2026
b887a8d
test: robustness
Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tsm/tsm-selection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ static struct line *get_next_line(struct tsm_screen *con, struct line *line, uns
return next;
*index = 0;
return con->lines[0];
} else if (*index < con->size_y) {
} else if (*index < con->size_y - 1) {
(*index)++;
return con->lines[*index];
}
Expand Down
21 changes: 13 additions & 8 deletions test/test_selection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,9 +818,10 @@ START_TEST(test_screen_robustness)
struct tsm_screen *screen;
int sb_size = 500;
int size_x, size_y;
int r, i;
int r, i, j;
char *str = NULL;


srand(0x12345678);

r = tsm_screen_new(&screen, NULL, NULL);
Expand All @@ -833,21 +834,25 @@ START_TEST(test_screen_robustness)

write_random_string(screen, 600);

for (i = 0; i < 500; i++) {
for (i = 0; i < 300; i++) {
size_x = 1 + rand() % 100;
size_y = 1 + rand() % 100;
printf("screen size: %dx%d\n", size_x, size_y);
r = tsm_screen_resize(screen, size_x, size_y);
ck_assert_int_eq(r, 0);

tsm_screen_scroll_up(screen, rand() % sb_size);
tsm_screen_scroll_down(screen, rand() % sb_size);
tsm_screen_selection_start(screen, rand() % size_x, rand() % size_y);
tsm_screen_selection_target(screen, rand() % size_x, rand() % size_y);
r = tsm_screen_selection_copy(screen, &str);
ck_assert_int_ge(r, 0);
if (str) {
free(str);
str = NULL;
for (j = 0; j < 50; j++) {
r = tsm_screen_selection_copy(screen, &str);
ck_assert_int_ge(r, 0);
if (str) {
free(str);
str = NULL;
}
tsm_screen_scroll_up(screen, rand() % sb_size);
tsm_screen_scroll_down(screen, rand() % sb_size);
}
write_random_string(screen, rand() % 100);
}
Expand Down
Loading