fix: CamelCase author names fail automatic search matching#219
Open
rinseaid wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scoreMatch()calls.toLowerCase()before parsing authors, destroying the casing thatnormalizeForMatching()relies on to split prefixes like "McGowan" → "Mc Gowan"/([a-z])([A-Z])/gnever matches on already-lowercased input, so "mcgowan" stays unsplit and fails the author presence checkrequireAuthor: true, so these results getmatchScore: 0and fall below the 50-point thresholdrequireAuthor: falseFiles Changed
src/lib/utils/ranking-algorithm.ts.toLowerCase()before author parsing so CamelCase survives intonormalizeForMatching(). Add/iflag to split regex, move lowercase into filter comparison.tests/utils/ranking-algorithm.test.tsTesting
vitest run)AI Disclosure
Found the bug manually by tracing why automatic searches kept returning 0 grabs for Mc-prefix authors. Used Claude to help develop and validate the fix. All changes reviewed and tested against a live instance.