Fix cards example: fold select side-effects into reactiveProxy setters#39
Open
khusmann wants to merge 1 commit into
Open
Fix cards example: fold select side-effects into reactiveProxy setters#39khusmann wants to merge 1 commit into
khusmann wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Dynamic Column Cards example (
examples/cards.R) errored at render:Both
<select>elements boundvalue =and attached anonChangehandler. irid enforces one channel per DOM event (seeenforce_one_channel_per_eventinR/process_tags.R): achangeevent is either bound or handled, never both.Fix
Fold each select's
onChangeside-effects into thesetof areactiveProxy, which is the framework's idiom for running a synchronous side-effect on write:dataset_nameand resetsselected_columns/choice.selected_columnsand always snapschoiceback to""(the placeholder), replacing the oldevent$valueread with the incoming value.Verification
Launched the app and confirmed the page renders with no one-channel error.