Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
|
||
| export function renderNumberHighlyRounded(x: number, places = 0): string { | ||
| const rounded = formatToSignificantFigures(x, 3) | ||
| return separateNumber(rounded) |
There was a problem hiding this comment.
The places parameter is accepted but never used — all callers passing 0, 1, or 2 now silently get the same behavior (3 significant figures via formatToSignificantFigures).
This also changes the display format for existing callers: the old implementation produced compact labels like "1.50k", "2M", "1.50B", while this returns full numbers with thin-space separators (e.g., "1 500 000"). That's a significant visual change on Y-axis tick labels and tooltips.
If this is intentional, the places parameter should be removed to avoid confusion. If not, this may be a regression.
| title="Look up percentile" | ||
| /> | ||
| {showPercentileBox && ( | ||
| <div |
There was a problem hiding this comment.
Missing alt attribute on this <img> — screen readers won't be able to describe the button. Add something like alt="Look up percentile".
| export function renderNumberHighlyRounded(x: number, places = 0): string { | ||
| const rounded = formatToSignificantFigures(x, 3) | ||
| return separateNumber(rounded) | ||
| } No newline at end of file |
There was a problem hiding this comment.
nit: Missing newline at end of file.
Screenshots merge 247580d84ef2a8d7acc037fae7a6e22475d04695
|
1 participant
No description provided.