Skip to content

fix: update a2a-sdk compatibility#1865

Open
jsonmp-k8 wants to merge 1 commit into
kagent-dev:mainfrom
jsonmp-k8:a2a-sdk-1x
Open

fix: update a2a-sdk compatibility#1865
jsonmp-k8 wants to merge 1 commit into
kagent-dev:mainfrom
jsonmp-k8:a2a-sdk-1x

Conversation

@jsonmp-k8
Copy link
Copy Markdown
Contributor

@jsonmp-k8 jsonmp-k8 commented May 14, 2026

Summary

  • update Python packages to depend on a2a-sdk >=1.0.2 and refresh uv.lock to 1.0.3
  • move KAgent's internal A2A model usage to the SDK v0.3 compatibility namespace
  • add compatibility shims for removed a2a-sdk 0.3 server app helpers and google-adk imports while wiring 1.x request handlers/cards
  • update remote A2A tool middleware handling for the a2a-sdk 1.x client interceptor API

Testing

  • /private/tmp/a2a-inspect/bin/uv run ruff format && /private/tmp/a2a-inspect/bin/uv run ruff check
  • /private/tmp/a2a-inspect/bin/uv run pytest packages/kagent-core/tests/test_hitl_utils.py packages/kagent-core/tests/test_read_metadata_value.py packages/kagent-adk/tests/unittests/test_remote_a2a_tool.py packages/kagent-adk/tests/unittests/converters/test_event_converter.py packages/kagent-langgraph/tests/test_checkpointer.py (91 passed)
  • /private/tmp/a2a-inspect/bin/uv run pytest ./packages/**/tests/ (458 passed, 1 skipped)

Signed-off-by: jaison paul paul.jaison@gmail.com

Copilot AI review requested due to automatic review settings May 14, 2026 01:39
@github-actions github-actions Bot added the bug Something isn't working label May 14, 2026
@jsonmp-k8
Copy link
Copy Markdown
Contributor Author

jsonmp-k8 commented May 14, 2026

.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels May 14, 2026
@jsonmp-k8
Copy link
Copy Markdown
Contributor Author

Addressed the review concerns in the latest push:

  • Verified against a2a-sdk 1.0.3 that ClientCallInterceptor only defines before/after, then removed the legacy intercept method and updated the header propagation tests to exercise before.
  • Added comments around the google-adk import-order compatibility shims so the ruff E402 exceptions and restore call are intentional.
  • Added a descriptive getattr to the synthetic a2a.client.middleware module for unsupported symbols.
  • Capped a2a-sdk constraints at <2.0 and refreshed uv.lock.
  • Documented A2AFastAPIApplication as a name-compatible alias and restored the unrelated test_sap_ai_core.py blank line.

Validation after these changes:

  • /private/tmp/a2a-inspect/bin/uv run ruff format && /private/tmp/a2a-inspect/bin/uv run ruff check
  • /private/tmp/a2a-inspect/bin/uv run pytest packages/kagent-core/tests/test_hitl_utils.py packages/kagent-core/tests/test_read_metadata_value.py packages/kagent-adk/tests/unittests/test_remote_a2a_tool.py packages/kagent-adk/tests/unittests/converters/test_event_converter.py packages/kagent-langgraph/tests/test_checkpointer.py (91 passed)
  • /private/tmp/a2a-inspect/bin/uv run pytest ./packages/**/tests/ (458 passed, 1 skipped)

@jsonmp-k8 jsonmp-k8 force-pushed the a2a-sdk-1x branch 2 times, most recently from 65d7e63 to 862daef Compare May 14, 2026 02:31
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels May 14, 2026
Signed-off-by: Jaison Paul <paul.jaison@gmail.com>
@EItanya
Copy link
Copy Markdown
Contributor

EItanya commented May 14, 2026

Looks like the agents are failing to come up in the e2e tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants