Fix values for kagent CLI helm install profiles#1864
Open
EItanya wants to merge 1 commit into
Open
Conversation
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
EItanya
requested review from
iplay88keys,
jmhbh and
supreme-gg-gg
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the helm install profile YAML files used by the kagent CLI. The previous files nested agent toggles under an agents: parent key, but the kagent Helm chart's values.yaml declares each agent as a top-level key (e.g. k8s-agent.enabled). The profiles are now restructured to match the chart's actual value schema so that --profile minimal|demo correctly enables/disables agents.
Changes:
- Move all agent entries in
minimal.yamlto the top level (removes the wrappingagents:key). - Move all agent entries in
demo.yamlto the top level (removes the wrappingagents:key).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go/core/cli/internal/profiles/minimal.yaml | Flattens agent toggles to top level so chart conditions like k8s-agent.enabled resolve correctly. |
| go/core/cli/internal/profiles/demo.yaml | Same flattening for the demo profile that enables all agents. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.