Skip to content

feat: remember window position and startup states#185

Draft
justnullname wants to merge 1 commit intomainfrom
feature/remember-window-position-4985793716670020909
Draft

feat: remember window position and startup states#185
justnullname wants to merge 1 commit intomainfrom
feature/remember-window-position-4985793716670020909

Conversation

@justnullname
Copy link
Copy Markdown
Owner

Closes #123 (Assume issue number based on prompt nature).
The issue highlighted that QuickView wasn't restoring a user's chosen window coordinates if it wasn't opened in fullscreen.

This PR upgrades the Remember last window size setting into Remember last window size and position.
It gracefully manages bounds loading from .ini, checks if the saved screen boundaries are valid across disconnected screens, correctly initializes fullscreen contexts via WM_COMMAND, and saves proper parameters through GetWindowPlacement without stomping values from maximized dimensions.


PR created automatically by Jules for task 4985793716670020909 started by @justnullname

…artup

- Updated AppStrings settings text for all languages to reflect the new functionality.
- Modified `WM_CLOSE` to record `LastWindowWasFullscreen`, `LastWindowWasMaximized`, `LastWindowX`, and `LastWindowY` in `QuickView.ini`.
- `GetWindowPlacement` is used to reliably determine the bounds rather than picking up full-screen dimensions from maximized states.
- On startup, the configuration triggers checking of saved `LastWindow` settings.
- Restored coordinate visibility is verified across displays using `MonitorFromRect` (better handling negative coords).
- Applied `SW_MAXIMIZE` to `nCmdShow` during bootstrapping for smooth loading of maximized windows.
- Fullscreen mode dynamically triggers upon creation.
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant