Update tooling-data.yaml by adding 2 tools#1830
Conversation
|
Hi @zx80! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1830 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 672 672
Branches 211 211
=========================================
Hits 672 672 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @zx80! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
Hello bot. ISTM that there is an issue reference (#1831) in the PR description. |
|
Hi @zx80! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
github-project-automation
Bot
moved this from Ready to review
to Done
in PR - Triage Group
|
@zx80 There's some documentation on how to connect a PR to an Issue here: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue |
|
@Relequestual: I closed this issue to use the form submission path instead. Should I reopen this one with keywords added to please de CI, or are the form submission sufficient and will be processed at some point in the future? |
|
@zx80 Once the GH Issue is done and agreed, you should re-open the PR or create a new one, your choice. The form is just a proxy for creating an Issue. Thanks. |
|
Hi @zx80! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
Ok… It seems that the check wanted a magic word before the issue reference which was already there. The automatic message is not really helpful. Sigh. |
|
Hello! Is there a particular issue concerning this 5 month old straightforward PR? |
|
@Relequestual I've been submitting the addition of these tools since May 2025… Is there a implicit policy that you do not want to add them? If so why? If not, do you have an approximate timeline for this patch to be processed, either merged or given some feedback? Thanks in advance, |
|
@json-schema-org/web-team Can we prioritize this. It's been waiting for a long time. |
|
📡 |
|
🎂 Happy anniversary! Over one year not to append 2 stupid tools (#1636, #1830, #1831, #1832, #1833). Over this period, the list was updated 25 times. If you do not want our tools in your list for whatever objective or subjective reason, feel free to say so and close. I will not resubmit anything, ever. |
|
Sorry, @zx80. We had a period where we didn't have anyone maintaining the website and some things got lost in that time. Also, my attempt to summon the web team failed because it turns out the new maintainers didn't get added to the team alias I pinged. I've corrected that problem now. Please resolve the conflicts and I'll ping our maintainers again to prioritize this issue. @AgniveshChaubey, @Utkarsh-123github Please ensure this gets reviewed and merged as soon as possible. Thanks. |
|
Hi @zx80 , |
Utkarsh-123github
left a comment
Utkarsh-123github
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thanks @zx80 for your contribution and efforts.
|
Congratulations, @zx80 for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema! |
4 participants
What kind of change does this PR introduce?
It adds to tools which are related to JSON Schema: a set of JSON Schema utils and a compiler which can export type description to JSON Schema.
Issue Number:
Closes #1831.
Screenshots/videos:
NA.
If relevant, did you update the documentation?
NA.
Summary
It adds new tools in the long list of available tools.
It is a re-submission of #1636 that I thought had been merged, but I was wrong.
I have removed the mention of the
nextversion as it seemed to generate some concerns.The combination of the two tools constitute a viable and rather fast JSON Schema compiler by using the schema-to-model converter of the first tool and the model compiler from the second tool.
Does this PR introduce a breaking change?
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.