fix checking a surrogate pair#232
fix checking a surrogate pair#232t-mangoe wants to merge 3 commits intojson-iterator:masterfrom t-mangoe:develop
Conversation
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
- Coverage 68.46% 68.45% -0.01%
==========================================
Files 107 107
Lines 7335 7336 +1
Branches 1388 1388
==========================================
Hits 5022 5022
- Misses 1867 1868 +1
Partials 446 446
Continue to review full report at Codecov.
|
| BigDecimal integerPart = new BigDecimal(value); | ||
| BigDecimal fractionalPart = new BigDecimal((decimalPart / (double) IterImplNumber.POW10[decimalPlaces])); | ||
| BigDecimal result = integerPart.add(fractionalPart).setScale(decimalPlaces,BigDecimal.ROUND_HALF_UP); | ||
| return result.doubleValue(); |
There was a problem hiding this comment.
@t-mangoe do you have tests and benchmarks that prove need for this change?
also I would move this commit to the separated pull request
There was a problem hiding this comment.
@plokhotnyuk Sorry. This commit targets another issue. I will revert this commit, and make separeted pull request. Thanks.
This reverts commit ec7bb60.
|
@t-mangoe please add tests for that case best option would be just checking of a whole range of surrogate pairs in some loop with an assertion for each pair |
3 participants
I fixed code. I think this fix solves the issue #207 . If you like, please merge.