Conversation
| } | ||
|
|
||
| @JRubyMethod(name = "mul") | ||
| public IRubyObject mul(final ThreadContext context, final IRubyObject[] args) { |
There was a problem hiding this comment.
I think there is at least one other math operation on ECPoint that this change now makes it easy to support: add
There was a problem hiding this comment.
Yes I'll do add in another PR!
fb9b026 to
6345910
Compare
|
Initial implementation is in place and appears to work for your simple example: I'm comparing uncompressed octet string output from each here. Better confirmation would be to run the related CRuby openssl tests, but there are other issues preventing us from running |
|
@alextwoods This now has @kares Review please! |
|
This works great! The AWS SDK For Ruby has a fairly extensive test suite for a signing algorithm based off of ECC and relies on the |
Gotta admit I'm surprised! But I think we can merge this in if @kares is ok with it. Fair warning: it's probably not going to be live until 0.15.0 releases unless we backport to 0.14 and do another release there. |
kares
left a comment
There was a problem hiding this comment.
There seems to be a regression, otherwise LGTM
|
I would like to add |
Work in progress. Fixes #306.