feat!: Refactor EnvelopeFromPart()'s scope#392
Merged
jhillyerd merged 3 commits intojhillyerd:mainfrom Apr 29, 2026
Merged
Conversation
…work is more aligned to the root aspect of a provided part. Also extracted the previous functionality into a new method on the Envelope type - GatherNestedErrors(). Also implemented GatherNestedErrors() within ReadEnvelope() after the call to EnvelopeFromPart() and added supporting test cases.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor EnvelopeFromPart()'s scope so that the functions's scope of work is more aligned to the root aspect of a provided part:
Why
The scope of the current form of EnvelopeFromPart is inconsistant in that the function's supposed purpose is to create a header from the root of a provided part, but the concluding body of the current form of EnvelopeFromPart() gathering errors from any/all nested/child/sibling parts. This is an effort to clarify the scope of work of EnvelopeFromPart to focus on any single part.
Testing
All current tests pass, and because the new method GatherNestedErrors() is also called ReadEnvelope(), ReadEnvelope()'s tests cover the GatherNestedErrors().
Note:
This is me actually following through on #372 - Better late than never.