Add validation error if required package not installed for the AM#604
Open
Add validation error if required package not installed for the AM#604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pre-flight validation for required system tools before Advanced Security scans
Summary
This PR adds a validation step that checks whether required system executables (
git,unzip,curl) are installed before running JFrog Advanced Security (JAS) scans. If any tool is missing from the system PATH, a clear error is returned early — preventing confusing downstream failures from the Analyzer Manager.Changes
jas/analyzermanager.go— Added ascannersRequiredInstalledSoftwarelist (git,unzip,curl) and a newValidateRequiredInstalledSoftware()function that usesexec.LookPathto verify each tool is available.commands/audit/audit.go— Call the new validation after confirming JAS entitlement and that a JAS scan is actually requested (viaIsJASRequested), returning early with a general error if validation fails.commands/scan/scan.go— Same validation gate added in the binary-scan init path (initScanCmdResults), so both audit and scan commands are covered.Notes
devbranch.go vet ./....go fmt ./....