Fix SwiftPM builds on non-Apple platforms#8
Open
jaumevn wants to merge 2 commits intoclaude/explain-codebase-nb6wlfrom
Open
Fix SwiftPM builds on non-Apple platforms#8jaumevn wants to merge 2 commits intoclaude/explain-codebase-nb6wlfrom
jaumevn wants to merge 2 commits intoclaude/explain-codebase-nb6wlfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
UIKit/CoreGraphicsimports and guarding Apple-only code.Description
#if canImport(AppKit)/#elseif canImport(UIKit)for platform imports andOSColortypealias inSource/UIColor+Hex.swiftso the library source compiles when AppKit/UIKit are not available.OSColorextension in#if canImport(AppKit) || canImport(UIKit)so those convenience initializers are only compiled on supported platforms.XColorTests/UIColorTests.swiftto conditionally import AppKit/UIKit under SwiftPM and guard theUIColor/NSColor-specific test class withcanImportchecks.XColorTests/Utils/UIColor+Helpers.swiftto usecanImportguards and wrap theOSColorhelper extension accordingly, and remove the unnecessaryimport CoreGraphicsfromXColorTests/XColorTests.swiftwhich caused failures on Linux.Testing
swift testdue tono such module 'UIKit'and laterno such module 'CoreGraphics'before changes.canImportguards and removing the Linux-incompatible import, ranswift testonx86_64-unknown-linux-gnuand all tests passed withExecuted 11 tests, with 0 failures.Codex Task