Minor refactor with if-let guards#145
Merged
itsjunetime merged 1 commit intoitsjunetime:mainfrom Apr 19, 2026
Merged
Conversation
itsjunetime
requested changes
Apr 19, 2026
Owner
itsjunetime
left a comment
itsjunetime
left a comment
There was a problem hiding this comment.
Thanks for doing this - I think I'd prefer that we not use tuples in this way, since they make the code somewhat more confusing to read over, but everything else I'm happy with :) if you'd be able to clean up the tuples, I'd be happy to merge this.
Owner
|
build issues cause of pathfinder_simd - you probably need to rebase onto/merge in main |
`if let` guards were stabilized in 1.95. The code concerning the TODO has been refactored.
dybucc
force-pushed
the
if-let-todo-done
branch
from
ce3f5ca to
bbba249
Compare
Contributor
Author
|
Sorry, that was the end of my "one expression, no statements" phase. #144 is more idiomatic. |
itsjunetime
approved these changes
Apr 19, 2026
Owner
itsjunetime
left a comment
itsjunetime
left a comment
There was a problem hiding this comment.
No worries, we've all been there haha. Thanks for fixing that up :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if letguards were stabilized in 1.95 [1]. The code concerning theTODOhas been refactored.