Fix shell script execution and config bugs#6
Open
ammaarrahmed wants to merge 1 commit intoirobot-ros:rollingfrom
Open
Fix shell script execution and config bugs#6ammaarrahmed wants to merge 1 commit intoirobot-ros:rollingfrom
ammaarrahmed wants to merge 1 commit intoirobot-ros:rollingfrom
Conversation
- Fix BUG-001: Correctly unset ROUTER_PID - Fix BUG-002: Preserve benchmark exit code before zenoh cleanup - Fix BUG-003: Add --results-dir to multi-process runner - Fix BUG-004: Pass ZENOH_ROUTER_CONFIG_URI to rmw_zenohd - Fix ISSUE-006: Correct memory_test.conf comment Signed-off-by: Ammaar Ahmed <ammaarlatif53@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for Benchmark Execution Scripts #5
This update resolves several critical bugs in the execution workflow that were affecting test reliability and data collection.
1. Fixed Zenoh Benchmark Exit Code Muting
kill ${ROUTER_PID}command. Ifirobot_benchmarkfailed but thekillsucceeded, the failure was silently ignored and the suite advanced.local benchmark_exit_code=$?) before the Zenoh cleanup block, ensuring failures are correctly caught and the script aborts.2. Fixed Incorrect Variable Unset Syntax
unset $ROUTER_PID(which evaluates the variable first, e.g.,unset 12345) instead ofunset ROUTER_PID. This is a no-op that leaves the PID variable defined, causing the next iteration's cleanup conditional to attempt killing the old, now defunct PID. This could potentially terminate unrelated processes on the host.unset ROUTER_PID.3. Added Missing
--results-dirto Multi-Process Runner--results-dirargument, causingirobot_benchmarkto dump logs in the current working directory/wsinstead of the targeted output folder. The script then relied on a fragilemv ./*log "$RESULT_FOLDER"glob, which caused errors in theSystemLatencyLoggerduring cleanup.--results-dir ${RESULT_FOLDER}to the execution command, aligning it with the single-process runner and removing the race condition.4. Applied Zenoh Router Custom Configs
ZENOH_ROUTER_CONFIG_URIfrom the test matrix, but never actually passed it to thermw_zenohdprocess. As a result, custom session configurations (like the critical timeout reductions documented in the CHANGELOG) were never applied, causing the router to trigger repeated "scouting delay" warnings.ZENOH_ROUTER_CONFIG_URIinto the environment before launchingrmw_zenohdso the RMW implementation picks it up.5. Corrected Minor Config Typo