Skip to content

chore(build): add Vercel preview builds for framework test apps#31073

Merged
ShaneK merged 2 commits intomainfrom
chore/vercel-previews
Apr 16, 2026
Merged

chore(build): add Vercel preview builds for framework test apps#31073
ShaneK merged 2 commits intomainfrom
chore/vercel-previews

Conversation

@ShaneK
Copy link
Copy Markdown
Member

@ShaneK ShaneK commented Apr 9, 2026

Issue number: resolves internal


What is the current behavior?

Vercel preview deployments only build and serve core Stencil component test pages. Framework-specific test apps (Angular, React, Vue, React Router) are not included, requiring developers to pull and build locally to validate them.

What is the new behavior?

Vercel preview deployments build and serve framework test apps alongside core component tests under a single preview URL.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ShaneK ShaneK requested a review from a team as a code owner April 9, 2026 19:20
@ShaneK ShaneK requested a review from brandyscarney April 9, 2026 19:20
@github-actions github-actions bot added the package: react @ionic/react package label Apr 9, 2026
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ionic-framework Ready Ready Preview, Comment Apr 14, 2026 5:17pm

Request Review

@ShaneK ShaneK force-pushed the chore/vercel-previews branch from 3bbcabf to 5eb431e Compare April 9, 2026 19:23
@github-actions github-actions bot added the package: core @ionic/core package label Apr 9, 2026
@ShaneK ShaneK force-pushed the chore/vercel-previews branch from 5eb431e to 91aa59e Compare April 9, 2026 19:27
@ShaneK ShaneK force-pushed the chore/vercel-previews branch from 91aa59e to e4f45f1 Compare April 9, 2026 19:33
@ShaneK ShaneK force-pushed the chore/vercel-previews branch from e4f45f1 to e785090 Compare April 9, 2026 19:42
@ShaneK ShaneK force-pushed the chore/vercel-previews branch from e785090 to 60b1804 Compare April 9, 2026 19:48
@ShaneK ShaneK force-pushed the chore/vercel-previews branch from 60b1804 to b5c7660 Compare April 9, 2026 19:57
@ShaneK ShaneK force-pushed the chore/vercel-previews branch from b5c7660 to 2e41f54 Compare April 9, 2026 20:05
@ShaneK ShaneK force-pushed the chore/vercel-previews branch from 2e41f54 to 192f551 Compare April 9, 2026 20:12
@ShaneK ShaneK force-pushed the chore/vercel-previews branch from 192f551 to 99f295a Compare April 9, 2026 20:39
Copy link
Copy Markdown
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly requesting for the sync command.

Question: Is it possible to add a way where we can determine if we want to build the frameworks? That way if we only need core then we don't have to wait for the others to build. It can be a label that is added to the PR or text command that is submitted through the comments, etc.

Comment thread core/scripts/vercel-build.sh
Comment thread core/scripts/vercel-build.sh
Comment thread core/scripts/vercel-build.sh Outdated
Comment thread core/scripts/vercel-build.sh Outdated
Comment thread core/scripts/vercel-build.sh Outdated
Comment thread packages/react/test/base/src/App.tsx
@ShaneK
Copy link
Copy Markdown
Member Author

ShaneK commented Apr 14, 2026

RE: Your review comment:

Not really, unfortunately. If we relied on code-based suggestion, we'd be building most of the time anyway (we need to build them all any time core changes). If we went the tag route, we'd have to make some annoying changes to Vercel, including giving it a GitHub token to read that I think. I'm pretty sure what it currently has access to isn't enough to pull labels like that.

@ShaneK ShaneK requested a review from thetaPC April 14, 2026 17:47
Copy link
Copy Markdown
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much!!

@ShaneK ShaneK added this pull request to the merge queue Apr 16, 2026
Merged via the queue into main with commit 0c178ef Apr 16, 2026
91 of 96 checks passed
@ShaneK ShaneK deleted the chore/vercel-previews branch April 16, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package package: react @ionic/react package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants