Make sure input has correct format in generateCTXEnvironment#4832
Open
bboldi wants to merge 6 commits intoionic-team:developfrom
Open
Make sure input has correct format in generateCTXEnvironment#4832bboldi wants to merge 6 commits intoionic-team:developfrom
bboldi wants to merge 6 commits intoionic-team:developfrom
Conversation
I ran into some cases where input was undefined, and ionic run failed with `TypeError: Cannot convert undefined or null to object` , I propose making sure that input will not break the build process if there's something wrong with json config that it uses values from to run hooks.
Author
|
Did I miss something? Do I need to do anything else to get this reviewed? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into some cases where input was undefined, and ionic run failed with
TypeError: Cannot convert undefined or null to object, I propose making sure that input will not break the build process if there's something wrong with json config that it uses values from to run hooks.