Skip to content

Added keep open boolean field to Stock Location modal form#11074

Open
spamik wants to merge 8 commits intoinventree:masterfrom
spamik:form-keep-open-feature
Open

Added keep open boolean field to Stock Location modal form#11074
spamik wants to merge 8 commits intoinventree:masterfrom
spamik:form-keep-open-feature

Conversation

@spamik
Copy link

@spamik spamik commented Jan 1, 2026

Added new boolean form field to Stock Location modal form which allows to keep form open after submitting instead closing it and redirecting browser to new stock location. This was discussed in this FR: #10412

@netlify
Copy link

netlify bot commented Jan 1, 2026

Deploy Preview for inventree-web-pui-preview failed.

Name Link
🔨 Latest commit 787b8e0
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/69ad6364142cf20008d095f5

},
location_type: {}
location_type: {},
keep_form_open: keepFormOpenField(create)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not really like this method here, I would prefer a generic approach here. What do you mean @SchrodingersGat ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does seem out of step with how are pass other parameters. It could be a simple keep_form_open attribute

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we have this parameter for all forms on InvenTree (if it's not disabled for that form) and then don't mix the form fields with the keep open toggle we render independently at the bottom of keep open is available for that form?

@spamik
Copy link
Author

spamik commented Jan 8, 2026

Ok, I've rewrited it a little. What about now? Calling method is gone. I had to still leave there some parameter passing because I didn't figured out how to hide this field in edit forms in some other way.

@SchrodingersGat SchrodingersGat added this to the 1.3.0 milestone Feb 12, 2026
@SchrodingersGat
Copy link
Member

The button should not be within the form itself - place it down in the bottom bar:

image

@spamik
Copy link
Author

spamik commented Mar 8, 2026

Ok, I now rewritted it as a form property, enabled on create forms.

Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants