Conversation
|
should be combined with #12 and the ongoing effort to make the translation easier |
|
I think we should merge this one now. Otherwise the package-lock issue may crop up when we try to do a release. We can then upgrade or change both the release and test workflows when we have a better translation routine. |
Samk13
left a comment
There was a problem hiding this comment.
Question: Do we actually need inputs.translations-working-directory here?
We never use it translation_dir is auto-detected via determine_js_path (same pattern as the publish workflow).
Can we align tests-js.yml with the publish workflow? i.e., drop inputs.js-working-directory and inputs.translations-working-directory, rely on determine_js_path (steps.determine_js_path.outputs.translation_dir) for gating + working-directory, and copy the same Node setup + build steps. This removes unused inputs and matches the behavior we ship in publish.
|
@zzacharo since you have followed the translations developments, can you please have a look? |
❤️ Thank you for your contribution!
Description
We should include the js translation build steps in the CI, to avoid issues like https://github.com/inveniosoftware/invenio-app-rdm/actions/runs/16355943075/job/46214227478 that only show up when running the release.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: