Skip to content

[MKT-841]:feat/checkout flow improves for new annual plans#1947

Merged
jaaaaavier merged 2 commits intomasterfrom
feat/checkout-immproves-for-montlhy-plans
May 5, 2026
Merged

[MKT-841]:feat/checkout flow improves for new annual plans#1947
jaaaaavier merged 2 commits intomasterfrom
feat/checkout-immproves-for-montlhy-plans

Conversation

@jaaaaavier
Copy link
Copy Markdown
Contributor

@jaaaaavier jaaaaavier commented May 5, 2026

Description

In this PR, we’re updating a couple of things in the checkout flow in connection with the recent deployment of new annual plans. Key changes:

  • We have replaced the content of renewalTitle.monthly (using monthly since that’s what is coming from the EP and it’s the simplest solution) with the text we need now. We might be able to implement some different logic, but this seems like a straightforward solution that will work for the moment.
  • Added a new entry, annualBillingTemplate, which informs the user about how the plan they are about to subscribe to works; this text has been added to the checkout component
  • Fixed a small bug that displayed an incorrect price in one of our dialogs
  • Updated the billing type in the plan card header

Related Issues

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Nothing out of the ordinary—just making sure everything is working as expected and everything is displayed correctly.

Additional Notes

@jaaaaavier jaaaaavier self-assigned this May 5, 2026
@jaaaaavier jaaaaavier added the enhancement New feature or request label May 5, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 5, 2026

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4910fcd
Status: ✅  Deploy successful!
Preview URL: https://cfced935.drive-web.pages.dev
Branch Preview URL: https://feat-checkout-immproves-for.drive-web.pages.dev

View logs

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 5, 2026

@jaaaaavier jaaaaavier marked this pull request as ready for review May 5, 2026 14:32
Copy link
Copy Markdown
Contributor

@xabg2 xabg2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to improve this, as using monthly checks for annual texts is confusing.

@jaaaaavier jaaaaavier merged commit e6a9c71 into master May 5, 2026
11 checks passed
@jaaaaavier jaaaaavier deleted the feat/checkout-immproves-for-montlhy-plans branch May 5, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants