Merged
Conversation
Remove .orElseThrow() calls from tests where the SDK now returns non-optional types for id and conversation_id fields: - ContactsCreateResponse.getId() now returns String - Conversation.getId() now returns String - Message.getConversationId() now returns String - Note.getId() now returns String Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update MessagesTest, IntegrationTest, and CompaniesTest to remove .orElseThrow() calls that are no longer needed since the SDK now returns non-optional types. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
sduquej
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The older version of the SDK used a runtime serialization layer that was more forgiving. It would handle missing or undefined fields gracefully at runtime, even if they weren't explicitly typed as optional. Now, we generate cleaner TypeScript types with no runtime overhead. The trade off though is that these types strictly follow OpenAPI semantics -- and in OpenAPI 3.x, fields are optional unless explicitly listed in a required array. See here: https://spec.openapis.org/oas/v3.0.3.html#schema