Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
src/interfaces/fuzz.rs
Outdated
| if self.should_auto_continue_repro() { | ||
| run_alone(|| { | ||
| continue_simulation(0)?; | ||
| Ok(()) | ||
| })?; | ||
| } else { | ||
| info!( | ||
| self.as_conf_object(), | ||
| "Repro testcase prepared; waiting for external resume." | ||
| ); | ||
| } |
There was a problem hiding this comment.
The new repro_auto_continue behavior (skipping continue_simulation and emitting an info log) is not covered by any existing integration test. Consider adding a Simics test that sets @tsffs.repro_auto_continue = False, triggers repro execution, and asserts the run remains stopped (or at least that the "waiting for external resume" log message is emitted) to prevent regressions in repro/debugger workflows.
src/haps/mod.rs
Outdated
| if self.should_auto_continue_repro() { | ||
| debug!(self.as_conf_object(), "Resuming simulation"); | ||
|
|
||
| run_alone(|| { | ||
| continue_simulation(0)?; | ||
| Ok(()) | ||
| })?; | ||
| run_alone(|| { | ||
| continue_simulation(0)?; | ||
| Ok(()) | ||
| })?; | ||
| } else { | ||
| info!( | ||
| self.as_conf_object(), | ||
| "Repro testcase prepared; waiting for external resume." | ||
| ); | ||
| } |
There was a problem hiding this comment.
This auto-continue gating block (check + continue_simulation vs info log) is duplicated in multiple handlers in this file. To avoid future divergence (e.g., updating the message or adding additional repro prep steps in one place but not others), consider extracting a small helper on Tsffs (or a local function) that performs the conditional resume + logging in one place.
Wenzel
force-pushed
the
feat/repro_continue
branch
from
6a4e40b to
701b4a6
Compare
No description provided.