Load the resolution plugin's stylesheet (hasCSS was missing)#6
Merged
Conversation
resolution/plugin.css sets the explicit slide box (width/height from --v-width/--v-height), box-sizing, and margin: auto letterboxing, but the plugin didn't export `hasCSS`, so the core loader skipped it. The deck still scaled to fit via the plugin's JS zoom, so it looked roughly right, but the exact resolution box was never applied. Export hasCSS = true. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
DmitrySharabin
force-pushed
the
load-missing-plugin-css
branch
from
26da8a3 to
fac1d79
Compare
DmitrySharabin
changed the title
LeaVerou
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
resolution/plugin.cssexists but the plugin didn'texport const hasCSS = true, so the core loader (which injectsplugin.cssonly whenmodule.hasCSSis truthy) skipped it. The explicit slide box (width/heightfrom--v-width/--v-height),box-sizing, andmargin: autoletterboxing never applied — the deck still scaled to fit via the plugin's JSzoom, so it looked roughly right, but the exact resolution box was missing.Fix
export const hasCSS = true;, matching the other CSS-bearing plugins.Verified (Playwright)
Core injects
<link id="plugin-css-resolution">; the slide becomes a1920×1080,box-sizing: border-box,margin: auto(centered) box (it filled the viewport before).Related
Same class of bug, fixed per-plugin: timer (#5) and visible-keys (#7).
🤖 Generated with Claude Code