feat: add bundle types, feasibility checking, and SDK improvements #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
force-pushed
the
feature/sdk-gap-analysis
branch
4 times, most recently
from
3a2679e to
6a9ac37
Compare
Add bundle types and serialization: - EthBundle, EthCall, CallBundle types matching Rust SDK - JSON serialization functions for bundle interchange - Test vectors generated from Rust SDK for cross-impl verification Add feasibility checking utilities: - checkOrderFeasibility for basic order validation - checkFillFeasibility for fill validation against orders - Detailed error types for each validation failure Additional improvements: - Enhanced nonce utilities (splitNonce, joinNonce, incrementNonce) - Builder pattern tests for order and fill construction - Edge case tests for validation and encoding - Permit2 ABI for token approval handling - Expanded Anvil integration tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
prestwich
force-pushed
the
feature/sdk-gap-analysis
branch
from
6a9ac37 to
b58f8d0
Compare
On-chain operation wrappers that every Signet dApp needs: - passage: enter() and enterToken() for Host to Signet bridging - weth: wrapEth() and unwrapEth() for WETH deposit/withdraw - permit2: getPermit2Allowance(), approvePermit2(), ensurePermit2Approval() with USDT-style reset-to-zero handling Also adds USDC/USDT addresses to Parmigiana token registry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EthBundle,EthCall,CallBundle) matching the Rust SDK for cross-implementation compatibilitycheckOrderFeasibility,checkFillFeasibility) for validating orders and fillssplitNonce,joinNonce,incrementNonce)Test plan
🤖 Generated with Claude Code