feat: add testnet token decimals and fix needsWethWrap flow logic #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add chain-specific token decimal overrides and disambiguate the
needsWethWrap function by requiring a flow parameter.
- Add tokenDecimals field to SignetSystemConstants for testnet overrides
- Add WUSD: 18 override to PARMIGIANA (mainnet uses 6)
- Add getTokenDecimals(symbol, config?) helper function
- Add Flow type ("passage" | "orders") to distinguish entry mechanisms
- Update needsWethWrap to require flow parameter (breaking change)
- Add RPC Patterns documentation section to README
Closes #11
Closes #14
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tokenDecimalsfield toSignetSystemConstantsfor chain-specific decimal overridesgetTokenDecimals(symbol, config?)helper that respects testnet overridesFlowtype ("passage"|"orders") to distinguish entry mechanismsneedsWethWrap(symbol, direction, flow)to require flow parameterDetails
Issue #11: Testnet token decimals
PARMIGIANA uses 18 decimals for WUSD instead of mainnet's 6. The new
tokenDecimalsfield on chain configs allows per-chain overrides, andgetTokenDecimals()provides a convenient lookup.Issue #14: needsWethWrap logic
The function was ambiguous because it conflated two entry mechanisms:
enter()accepts native ETH directly - no wrap neededThe new
flowparameter makes this explicit.Test plan
pnpm typecheckpassespnpm test:runpasses (192 tests)pnpm lintpassespnpm formatpassesgetTokenDecimalsand updatedneedsWethWraptestsCloses #11
Closes #14
🤖 Generated with Claude Code