chore: update to match changed dependencies #216
Conversation
Fraser999
requested review from
Evalir,
dylanlott and
prestwich
as code owners
| #![cfg_attr(not(test), warn(unused_crate_dependencies))] | ||
| #![deny(unused_must_use, rust_2018_idioms)] | ||
| #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))] | ||
| #![recursion_limit = "256"] |
There was a problem hiding this comment.
Without this, we get:
error: queries overflow the depth limit!
|
= help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`builder`)
= note: query depth increased by 130 when computing layout of `{async fn body of config::<impl at src/config.rs:173:1: 173:19>::connect_builder_signer()}`
It seems reasonable to just take the compiler's advice here. We're only just over the default limit of 128, and presumably that happened due a slight increase in complexity of type nesting in one of the updated deps.
.gitignore
Outdated
| .vscode/launch.json No newline at end of file | ||
| .vscode/launch.json | ||
|
|
||
| .claude/ |
There was a problem hiding this comment.
I don't think we want to add .claude/ to the gitignore since we're adding skills for individual repos instead of centralizing them.
There was a problem hiding this comment.
It's handy to have this ignored since claude code will create .claude/settings.local.json if you do something like give it permission to always do a web search while working in that repo. I guess we should be more specific and just ignore the .local.json file?
There was a problem hiding this comment.
Agreed that's a better pattern for this.
.gitignore
Outdated
| .vscode/launch.json No newline at end of file | ||
| .vscode/launch.json | ||
|
|
||
| .claude/ |
There was a problem hiding this comment.
Agreed that's a better pattern for this.
2 participants
No description provided.