feat(submit): pylon blob preloading integration #215
Conversation
prestwich
left a comment
prestwich
left a comment
There was a problem hiding this comment.
i think the task is too heavy. we just need a fire-and-forget dispatch in the flashbots spawned future. I also think we're duplicating the sidecar and passing it around too much?
src/tasks/submit/flashbots.rs
Outdated
| /// Builds a MEV bundle from a signed transaction envelope and simulation result. | ||
| fn build_bundle(&self, envelope: &TxEnvelope, sim_result: &SimResult) -> EthSendBundle { | ||
| let tx_bytes: Bytes = envelope.encoded_2718().into(); | ||
| let txs = self.build_bundle_body(sim_result, tx_bytes); |
There was a problem hiding this comment.
refactor while we're here: the build_bundle_body method doesn't use self. which implies that it is on the wrong type. what type should it be on?
There was a problem hiding this comment.
this is something i was kinda pondering before, along with sidecar things. both building the sidecar, and the bundle body, could live on SimResult? it doesn't really change once returned, so it could just be memoized
Evalir
force-pushed
the
evalir/pylon-integration
branch
from
452582a to
c53b448
Compare
Evalir
force-pushed
the
evalir/pylon-integration
branch
from
091a379 to
fb4b0e1
Compare
| "Submitted MEV bundle to Flashbots, received OK response" | ||
| ); | ||
|
|
||
| match pylon.post_blob_tx(block_tx).await { |
There was a problem hiding this comment.
this is too much nesting. refactor to use early returns and avoid nesting matches
2 participants
No description provided.