This repository was archived by the owner on May 16, 2026. It is now read-only.
Update module requirements and coding standard#276
Merged
Conversation
Sync both documents and add missing requirements: - Add documentation deps (mkdocs-material, mkdocs-glightbox, diagrams, mkdocs-minify-plugin) - Add mkdocs.yml requirements (site_name pattern, glightbox plugin) - Add checkov security dependency and .checkov.yml requirement - Add AWS provider version parametrize pattern for tests - Add make bootstrap must install pre-commit hooks - Add full do_release Makefile function with safety checks - Sync badge order and format between both documents - Promote architecture/examples/troubleshooting/changelog to required pages - Specify changelog.md as symlink to CHANGELOG.md - Remove stale sections (implementation plan, proposed coding standard updates, repo settings) - Remove .github/ISSUE_TEMPLATE and PULL_REQUEST_TEMPLATE from should-have Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Comment was too big. Check the CI workflow output. |
akuzminsky
commented
May 6, 2026
Collaborator
Author
akuzminsky
left a comment
There was a problem hiding this comment.
Plan passed: 0 to add, 123 to change, 0 to destroy.
All 123 changes are coding_standard and terraform_module_requirements file updates pushed to managed repos. No unexpected resource changes.
Changes reviewed:
- CODING_STANDARD.md: Promoted architecture/examples/troubleshooting/changelog docs pages to required, changelog.md specified as symlink, removed .github/ISSUE_TEMPLATE and PULL_REQUEST_TEMPLATE from should-have
- TERRAFORM_MODULE_REQUIREMENTS.md: Added documentation deps (mkdocs-material, mkdocs-glightbox, diagrams, mkdocs-minify-plugin), mkdocs.yml config requirements (site_name pattern, glightbox plugin), checkov security dep and .checkov.yml, AWS 6.x provider parametrize pattern, make bootstrap hook install requirement, full do_release Makefile function, synced badge order with CODING_STANDARD.md, removed stale sections (implementation plan, proposed coding standard updates, repo settings)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.checkov.ymlrequirement, AWS 6.x provider parametrize pattern, and fulldo_releaseMakefile function with safety checksTest plan
🤖 Generated with Claude Code