Merged
Conversation
- Add React 18 support while maintaining backward compatibility - Update to @cfaester/enzyme-adapter-react-18 for React 18 testing - Upgrade Jest to v29 with jsdom environment
Member
|
We use react 17 in Indico, so that react version needs to be supported by react-overridable. |
Contributor
Author
this shouldn't break anything using react 17, as it touches just the testing dev deps |
Contributor
|
@ThiefMaster I had a look at @mirekys demos (I pushed them here) and I think this PR is good to merge 👍 |
Member
|
Since this involves dependency updates, please add a |
Fix CI errors in mirekys/react18-support branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps deps to React 18 while maintaining backward compatibility with React 16 and 17.