perf(cli/install): bounded pool for collectFormulaJobs#141
Merged
Conversation
Replace one-thread-per-dep in the dep-fetch phase with a bounded pool sharing the atomic-index primitive materializePoolWorker already uses. Heavy dep graphs no longer over-allocate thread stacks that then block on the 4-slot HTTP client pool; ffmpeg-sized graphs behave identically. Generated with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Install's dep-formula fetch phase spawned one thread per dependency and then queued them against a 4-slot HTTP client pool - extra threads just sat idle waiting for a client. On heavy graphs (40+ deps) that's 20+ wasted stacks and a lot of pool contention; on small graphs like ffmpeg (11 deps) the behaviour is unchanged.
Replace it with the same bounded atomic-index pool pattern
materializePoolWorkeralready uses: a fixed set of workers share onefetchAddindex and drain the dep array. Workers never outnumber HTTP client slots, so none of them stall onpool.acquire.Related Issue
Notes for Reviewers
MAX_COLLECT_FETCH_WORKERS = 4) so the value and its rationale are co-located.