Skip to content

#93 - Allow user to specify binary mirror#94

Closed
ConfuddledPenguin wants to merge 2 commits intoimagemin:masterfrom
ConfuddledPenguin:master
Closed

#93 - Allow user to specify binary mirror#94
ConfuddledPenguin wants to merge 2 commits intoimagemin:masterfrom
ConfuddledPenguin:master

Conversation

@ConfuddledPenguin
Copy link
Copy Markdown

Allowing configuration of the download URL of the binary files via enviroment variables for users that are not able to download the binary files from github.

@magicdawn
Copy link
Copy Markdown

I can not reach raw.githubcontent.com in China. But jsdelivr github cdn works fine

@ConfuddledPenguin
Copy link
Copy Markdown
Author

A PR open against bin wrapper (used to manage the binary dependencies) do perform this in a more generic way: kevva/bin-wrapper#73

@aniude
Copy link
Copy Markdown

aniude commented Mar 12, 2020

@magicdawn use the taobao mirror. https://npm.taobao.org/mirrors/jpegtran-bin/

@1000ch
Copy link
Copy Markdown
Contributor

1000ch commented May 29, 2020

Thank you for your contribution, now this is solved by including the source (#96).

@1000ch 1000ch closed this May 29, 2020
@gera2ld
Copy link
Copy Markdown

gera2ld commented Jun 12, 2020

#96 does not really solve this problem in slow network, because download always tries to download the binary file first, and hangs until the connection times out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants