feat: rework igo-signal into igo-component#46
Open
mickael-coquer-igocreate wants to merge 2 commits intov6from
Open
feat: rework igo-signal into igo-component#46mickael-coquer-igocreate wants to merge 2 commits intov6from
mickael-coquer-igocreate wants to merge 2 commits intov6from
Conversation
4586b2f to
bf02b28
Compare
Author
Code reviewFound 1 issue:
igo/packages/component/src/server/ComponentController.js Lines 39 to 53 in bf02b28 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
bf02b28 to
957f847
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@igojs/signalpackage to@igojs/componentto better reflect its purposeComponentLoaderfor automatic client-side component loadingComponentControllerandComponentHelperfor server-side component renderingComponentSplitterin dust package for single-file component compilationcreate.js(recursivereplaceInDirectorymissingreplacementsparameter)Test plan
npm testto verify all existing tests passComponentHelperTestandComponentSplitterTestpassigo createscaffolding works correctly{@component}helper🤖 Generated with Claude Code