Skip to content

Fix Ice TODOs, update docs.zeroc.com references#474

Merged
bernardnormier merged 7 commits intoicerpc:csharp-0.6-devfrom
bernardnormier:ice-links
Apr 14, 2026
Merged

Fix Ice TODOs, update docs.zeroc.com references#474
bernardnormier merged 7 commits intoicerpc:csharp-0.6-devfrom
bernardnormier:ice-links

Conversation

@bernardnormier
Copy link
Copy Markdown
Member

Fixes #454

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates documentation to resolve remaining Ice-related TODOs and to point external Ice manual references at the Ice 3.8 docs (per #454).

Changes:

  • Removed unused link references from Slice encoding docs.
  • Updated Ice manual links (and switched to docs.zeroc.com), including the facet reference and ice protocol references.
  • Replaced “TODO: ice definitions” placeholders in the ice protocol frames page with concrete Ice IDL examples, and filled in a previously TODO C# metadata directive link.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
content/slice/encoding/user-defined-types.md Removes unused reference-style links at the end of the page.
content/icerpc/invocation/service-address.md Updates the external “Ice facet” link to Ice 3.8 docs.
content/icerpc/ice-protocol/protocol-frames.md Replaces TODO placeholders with Ice IDL examples and updates Ice manual reference links to 3.8.
content/icerpc-for-ice-users/ice-definitions/struct-types.md Replaces a TODO reference link for cs:readonly with the Ice 3.8 docs URL.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +115 to +123
Ok = 0,
UserException,
ObjectNotExist,
FacetNotExist,
OperationNotExist,
UnknownLocalException,
UnknownUserException,
UnknownException,
InvalidData,
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commas are required for the Ice syntax (ice code blocks). They are optional for the Slice syntax (slice code block).

Comment on lines +34 to +38
Request = 0,
RequestBatch = 1,
Reply = 2,
ValidateConnection = 3,
CloseConnection = 4,
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

Comment thread content/icerpc/ice-protocol/protocol-frames.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates documentation to remove remaining TODO placeholders in Ice protocol docs and to ensure external references point to the Ice 3.8 documentation (per #454).

Changes:

  • Replaced “TODO: ice definitions” placeholders in the IceRPC protocol frames doc with concrete Ice IDL snippets and updated related terminology/tables.
  • Updated external doc links from the old doc site/version to https://docs.zeroc.com/ice/3.8/....
  • Removed unused link reference definitions and replaced a remaining TODO link with a real URL.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
content/slice/encoding/user-defined-types.md Removes unused link reference definitions at the end of the page.
content/icerpc/invocation/service-address.md Updates the external “Ice facet” documentation link to Ice 3.8.
content/icerpc/ice-protocol/protocol-frames.md Fills in missing Ice IDL definitions and updates protocol/doc references to Ice 3.8.
content/icerpc-for-ice-users/ice-definitions/struct-types.md Replaces a TODO reference link for cs:readonly with the corresponding Ice 3.8 docs URL.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread content/icerpc/ice-protocol/protocol-frames.md Outdated
Comment thread content/icerpc/ice-protocol/protocol-frames.md Outdated
Comment thread content/icerpc-for-ice-users/ice-definitions/struct-types.md
bernardnormier and others added 2 commits April 14, 2026 09:15
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates documentation to remove stale TODOs and refresh external Ice Manual references to the Ice 3.8 docs site, aligning with issue #454.

Changes:

  • Replaced/updated external Ice Manual links to https://docs.zeroc.com/ice/3.8/....
  • Filled in previously “TODO: ice definitions” sections with concrete ice IDL snippets for protocol frames.
  • Removed unused link references and replaced a TODO link for cs:readonly with a real target.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
content/slice/encoding/user-defined-types.md Removes now-unused reference definitions (including an old Ice 3.7 link).
content/icerpc/invocation/service-address.md Updates the “Ice facet” external documentation link to the Ice 3.8 docs site.
content/icerpc/ice-protocol/protocol-frames.md Replaces TODO placeholders with ice definitions and updates Ice Manual links to 3.8.
content/icerpc-for-ice-users/ice-definitions/struct-types.md Fixes formatting around cs:readonly reference and replaces a TODO link with the Ice 3.8 target.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread content/icerpc/ice-protocol/protocol-frames.md
Comment thread content/icerpc/ice-protocol/protocol-frames.md
Comment thread content/icerpc/ice-protocol/protocol-frames.md
Comment thread content/icerpc/ice-protocol/protocol-frames.md Outdated
bernardnormier and others added 2 commits April 14, 2026 09:35
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@bernardnormier bernardnormier merged commit 1c37fe3 into icerpc:csharp-0.6-dev Apr 14, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants