Open
Conversation
kaushal02
requested review from
JBAhire,
puneet-traceable,
ryanericson,
shashank11p and
tyroneyu
and removed request for
JBAhire
shashank11p
reviewed
Mar 23, 2023
Contributor
shashank11p
left a comment
shashank11p
left a comment
There was a problem hiding this comment.
@kaushal02 there are some TODOs and FIXMEs pending
...ent/instrumentation/hypertrace/servlet/v2_2/nowrapping/Servlet2AndFilterInstrumentation.java
Outdated
Show resolved
Hide resolved
...ent/instrumentation/hypertrace/servlet/v2_2/nowrapping/Servlet2AndFilterInstrumentation.java
Outdated
Show resolved
Hide resolved
...nstrumentation/hypertrace/servlet/v2_2/nowrapping/request/ServletRequestInstrumentation.java
Outdated
Show resolved
Hide resolved
| .and(isPublic()), | ||
| ServletOutputStreamInstrumentation.class.getName() + "$OutputStream_writeByteArrOffset"); | ||
|
|
||
| // close() is not instrumented due to some issue with Tomcat |
Contributor
There was a problem hiding this comment.
Should we instrument this method in 2.0? We should check this method in servlet-2.0 code
...nstrumentation/hypertrace/servlet/v3_0/nowrapping/request/ServletRequestInstrumentation.java
Outdated
Show resolved
Hide resolved
...pentelemetry/javaagent/instrumentation/hypertrace/servlet/v3_0/nowrapping/request/Utils.java
Outdated
Show resolved
Hide resolved
Contributor
|
@kaushal02 we should add tests as well |
shashank11p
reviewed
Mar 23, 2023
...pentelemetry/javaagent/instrumentation/hypertrace/servlet/v3_0/nowrapping/request/Utils.java
Outdated
Show resolved
Hide resolved
| VirtualField.find(HttpServletRequest.class, StringMapSpanPair.class); | ||
|
|
||
| // capture response body | ||
| // TODO: capture response headers |
Contributor
There was a problem hiding this comment.
Are we able to capture response headers?
Author
There was a problem hiding this comment.
we are capturing content-type header but other response headers are not getting captured, at least in case of Boomi
shashank11p
reviewed
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding instrumentation for old servlet versions (2.2-3.0). This is used in boomi. The implementation is almost similar to servlet-3.0.
Testing
Tested with rest API in boomi which uses servlet-2.5 and able to instrument everything there except response headers.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.