Skip to content

fix: Upgrade to angular v20#1415

Merged
knagurski merged 5 commits intomainfrom
aui-34-upgrade-to-angular-v20
Feb 6, 2026
Merged

fix: Upgrade to angular v20#1415
knagurski merged 5 commits intomainfrom
aui-34-upgrade-to-angular-v20

Conversation

@knagurski
Copy link
Collaborator

Description

Update the library to use Angular 20

Testing

Loaded within the outer Angular 20 app.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@knagurski knagurski self-assigned this Feb 2, 2026
@knagurski knagurski requested a review from a team as a code owner February 2, 2026 18:16
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Test Results

53 tests  ±0   53 ✅ ±0   14s ⏱️ ±0s
15 suites ±0    0 💤 ±0 
 2 files   ±0    0 ❌ ±0 

Results for commit 1ca1dc1. ± Comparison against base commit 6830e9f.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.67%. Comparing base (6830e9f) to head (1ca1dc1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1415   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          49       49           
  Lines         617      617           
  Branches       39       36    -3     
=======================================
  Hits          615      615           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knagurski knagurski changed the title Aui 34 upgrade to angular v20 fix: Upgrade to angular v20 Feb 2, 2026
Comment on lines -1 to -3
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Husky no longer requires this stuff

Comment on lines -20 to -21
"@angular-devkit/build-angular": "^19.0.6",
"core-js": "^3.39.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These weren't used by the library

"extends": "../../tsconfig.json",
"compilerOptions": {
"outDir": "../../out-tsc/spec",
"types": ["webpack-env", "jest"],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Webpack isn't used in this project

adisreyaj
adisreyaj previously approved these changes Feb 5, 2026
"@angular/common": "^19.0.5",
"@angular/core": "^19.0.5",
"@angular/platform-browser": "^19.0.5",
"@angular-devkit/build-angular": "^19.0.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought this is used for build related stuff.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a library, it doesn't get "built", it's up to the consuming app

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does - because it gets packaged up and published. There's also an application this repo (src dir) that historically has been used for developing + debugging this library.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the package level, the app around it has the appropriate builders and everything builds fine

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run build:ci works Screenshot 2026-02-05 at 21 16 52

@knagurski
Copy link
Collaborator Author

I've been doing some debugging and found the v7.1.1 works fine under Angular 19. v8.0.0 is totally broken. This PR builds fine, but there is an issue reported in the console. Will investigate

@knagurski
Copy link
Collaborator Author

knagurski commented Feb 5, 2026

I've been doing some debugging and found the v7.1.1 works fine under Angular 19. v8.0.0 is totally broken. This PR builds fine, but there is an issue reported in the console. Will investigate

Fixed now. The changes that went into v8.0.0 removed initialisation calls. I've added a commit that puts them back in to the app. The package worked without this change, but the app was broken.

Screenshot 2026-02-05 at 21 58 08

@knagurski knagurski merged commit b8a57e5 into main Feb 6, 2026
5 checks passed
@knagurski knagurski deleted the aui-34-upgrade-to-angular-v20 branch February 6, 2026 10:41
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

🎉 This PR is included in version 8.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants