fix(codegen): add self-FK on simulation_branches + four enum CHECKs#79
Merged
Merged
Conversation
Closes #43. The overlay DDL had no structural enforcement of: - `simulation_branches.parent_branch` referencing `branch_id` (self-referencing tree of branches) - the four enum-shaped TEXT columns: * `simulation_branches.status` ∈ {active, merged, abandoned} * `provenance_log.operation` ∈ {insert, update, delete, transform} * `access_policies.access_level` ∈ {read, write, admin, deny} * `lineage_graph.derivation_type` ∈ {copy, transform, aggregate, join, filter} Anything could be written to those columns; downstream consumers had to re-validate every row. Add the FK (NULL still allowed for root branches) and the four CHECK constraints. Test `test_overlay_has_enum_checks_and_fk` asserts each by substring against the generated DDL. `cargo clippy --all-targets -- -D warnings` clean; 36 unit tests pass. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per V-L2-J1: add structural enforcement that the overlay was missing.
simulation_branches.parent_branchself-referencing FK (NULL still allowed for root)simulation_branches.status∈ {active, merged, abandoned}provenance_log.operation∈ {insert, update, delete, transform}access_policies.access_level∈ {read, write, admin, deny}lineage_graph.derivation_type∈ {copy, transform, aggregate, join, filter}Anything could be written to those columns before; downstream consumers had to re-validate every row.
Closes
Test plan
cargo clippy --all-targets -- -D warningscleancargo test --lib --bins36/36 (1 new:test_overlay_has_enum_checks_and_fk)