Rename MultiUseSandbox -> Sandbox, UninitializedSandbox::evolve -> UninitializedSandbox::init#762
Open
jprendes wants to merge 5 commits intohyperlight-dev:mainfrom
Open
Rename MultiUseSandbox -> Sandbox, UninitializedSandbox::evolve -> UninitializedSandbox::init#762jprendes wants to merge 5 commits intohyperlight-dev:mainfrom
MultiUseSandbox -> Sandbox, UninitializedSandbox::evolve -> UninitializedSandbox::init#762jprendes wants to merge 5 commits intohyperlight-dev:mainfrom
Conversation
jprendes
requested review from
danbugs,
dblnz,
devigned,
ludfjig,
marosset,
simongdavies and
syntactically
as code owners
jprendes
added
the
kind/refactor
ludfjig
previously approved these changes
Aug 4, 2025
Contributor
ludfjig
left a comment
ludfjig
left a comment
There was a problem hiding this comment.
Lgtm. I am thinking we might want to take this chance to do other breaking changes such as determining which module Sandbox belongs to, and whether or not we want to any re-exports of Sandbox at all.
| /// Re-export for `MemMgrWrapper` type | ||
| /// A sandbox that can call be used to make multiple calls to guest functions, | ||
| /// and otherwise reused multiple times | ||
| pub use sandbox::MultiUseSandbox; |
Contributor
There was a problem hiding this comment.
Maybe we can take this chance to remove these reexports? I'm not sure there is a reason to keep these?
Contributor
Author
There was a problem hiding this comment.
I opened #765 to see what we want to expose as our public API
ludfjig
previously approved these changes
Aug 5, 2025
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
MultiUseSandboxasSandbox.Rename
UninitializedSandbox::evolveasUninitializedSandbox::init