fixing enum compare to be case insensitive for FFEnumParseString#217
Merged
peterbroadhurst merged 2 commits intoJun 10, 2026
Merged
Conversation
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
| for _, possible := range e { | ||
| if possible == strings.ToLower(val) { | ||
| return FFEnum(strings.ToLower(val)), nil | ||
| possibleStr, ok := possible.(string) |
Contributor
There was a problem hiding this comment.
Just (string)possible simple type casting should be possible here for a known type, rather than interface
Contributor
Author
There was a problem hiding this comment.
I see. conversion to interface{} is only needed for FFEnumValues as that function is used for openapi.
Updated the code to make that clear.
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Among all functions apart from
Value(), the usage of enum values follows a case-insensitive pattern and treats lower case as canonical.This PR updates the FFEnumParseString to also be case-insensitive when looking up a string against registered values.