cache compiled schema and implement cache invalidation strategy#16
Open
srivastava-diya wants to merge 7 commits into
Open
cache compiled schema and implement cache invalidation strategy#16srivastava-diya wants to merge 7 commits into
srivastava-diya wants to merge 7 commits into
Conversation
jdesrosiers
requested changes
Jun 12, 2026
jdesrosiers
left a comment
jdesrosiers
left a comment
Collaborator
There was a problem hiding this comment.
We need to handle cache invalidation when a schema changes.
srivastava-diya
force-pushed
the
feature/schema-caching
branch
from
0ad2b54 to
46a1d63
Compare
srivastava-diya
changed the title
id to fixtureSchemaUri in schemaValidation test
use json-document model
srivastava-diya
force-pushed
the
feature/schema-caching
branch
from
006ca38 to
58f499e
Compare
srivastava-diya
commented
Jun 18, 2026
| schemaStore.clear(change.uri); | ||
| } | ||
|
|
||
| for (const document of documents.all()) { |
Collaborator
Author
There was a problem hiding this comment.
i am figuring out some way to find which open files reference the updated schema, until then i am looping through and revalidating all open documents.
Collaborator
Author
|
hey @jdesrosiers This PR is still a WIP, so I'm not looking for approval just yet. I'd really appreciate a review to make sure if I'm proceeding in the right direction before I continue implementing the other stuff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
validate(schemaUri)function is curried calling it with just the schema URI compiles the schema and returns a reusable validator function. Previously this compilation was happening on every keystroke.