Ensure oracle fees are paid independently by flopez7 · Pull Request #3899 · humanprotocol/human-protocol

flopez7 · 2026-05-13T09:06:54Z

Issue tracking

Context behind the change

Oracle fees were previously affected when worker submissions were rejected and no worker payout was made. This change separates oracle compensation from worker payouts so oracle fees are reserved from the funded amount and paid when the escrow is completed or canceled, while rejected submissions still receive no worker payout. The SDK, oracles, and subgraph were updated to use and track the corrected fund amounts and oracle fee transfers.

How has this been tested?

Deployed locally

Release plan

Deploy new contract version, SDKs and subgraph

Potential risks; What to monitor; Rollback plan

Check bulkpayout balance and fees.

vercel · 2026-05-13T09:07:00Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
human-app	Ready	Preview, Comment	May 15, 2026 10:42am
human-dashboard-frontend	Ready	Preview, Comment	May 15, 2026 10:42am
staking-dashboard	Ready	Preview, Comment	May 15, 2026 10:42am

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
faucet-frontend	Ignored	Preview	May 15, 2026 10:42am
faucet-server	Ignored	Preview	May 15, 2026 10:42am

…omplete/Cancel in the same transaction

portuu3 · 2026-05-13T13:22:16Z

+    chainId: number,
+    escrowAddress: string,
+  ): Promise<bigint> {
+    const fundAmount = await escrowClient.getFundAmount(escrowAddress);


I think you can use totalFundAmount from escrow data obtained in the next line.

…ead of rpc

…anceler address and event amount

portuu3 · 2026-05-14T13:30:44Z

        require(_recipients.length == _amounts.length, 'Length mismatch');
-        require(_amounts.length > 0, 'Empty amounts');
-        require(_recipients.length <= BULK_MAX_COUNT, 'Too many recipients');
+        uint256 length = _amounts.length;
+        require(length > 0, 'Empty amounts');
+        require(length <= BULK_MAX_COUNT, 'Too many recipients');


Suggested change

require(_recipients.length == _amounts.length, 'Length mismatch');

require(_amounts.length > 0, 'Empty amounts');

require(_recipients.length <= BULK_MAX_COUNT, 'Too many recipients');

uint256 length = _amounts.length;

require(length > 0, 'Empty amounts');

require(length <= BULK_MAX_COUNT, 'Too many recipients');

uint256 length = _amounts.length;

require(_recipients.length == length, 'Length mismatch');

require(length > 0, 'Empty amounts');

require(length <= BULK_MAX_COUNT, 'Too many recipients');

portuu3 · 2026-05-14T13:33:06Z

        EscrowStatuses _status = status;
-        uint256 _remaining = remainingFunds;
+        uint256 _remainingFunds = remainingFunds;
+
+        uint256 _reputationOracleFee = (fundAmount *
+            reputationOracleFeePercentage) / 100;
+        uint256 _recordingOracleFee = (fundAmount *
+            recordingOracleFeePercentage) / 100;
+        uint256 _exchangeOracleFee = (fundAmount *
+            exchangeOracleFeePercentage) / 100;
+
+        IERC20 tokenContract = IERC20(token);

-        if (_remaining > 0) {
-            IERC20 tokenContract = IERC20(token);
-            tokenContract.safeTransfer(launcher, _remaining);
+        fundAmount = 0;
+        remainingFunds = 0;
+        reservedFunds = 0;
+
+        if (_reputationOracleFee > 0) {
+            tokenContract.safeTransfer(reputationOracle, _reputationOracleFee);
+        }
+        if (_recordingOracleFee > 0) {
+            tokenContract.safeTransfer(recordingOracle, _recordingOracleFee);
+        }
+        if (_exchangeOracleFee > 0) {
+            tokenContract.safeTransfer(exchangeOracle, _exchangeOracleFee);
+        }
+        if (
+            _reputationOracleFee > 0 ||
+            _recordingOracleFee > 0 ||
+            _exchangeOracleFee > 0
+        ) {
+            address[] memory oracles = new address[](3);
+            uint256[] memory amounts = new uint256[](3);
+
+            oracles[0] = reputationOracle;
+            oracles[1] = recordingOracle;
+            oracles[2] = exchangeOracle;
+
+            amounts[0] = _reputationOracleFee;
+            amounts[1] = _recordingOracleFee;
+            amounts[2] = _exchangeOracleFee;
+
+            emit OracleFeeTransfer(oracles, amounts);
+        }
+        if (_remainingFunds > 0) {
+            tokenContract.safeTransfer(launcher, _remainingFunds);
            if (_status == EscrowStatuses.ToCancel) {
-                emit CancellationRefund(_remaining);
+                emit CancellationRefund(_remainingFunds);
            }
-            remainingFunds = 0;
-            reservedFunds = 0;
        }


Suggested change

EscrowStatuses _status = status;

uint256 _remaining = remainingFunds;

uint256 _remainingFunds = remainingFunds;

uint256 _reputationOracleFee = (fundAmount *

reputationOracleFeePercentage) / 100;

uint256 _recordingOracleFee = (fundAmount *

recordingOracleFeePercentage) / 100;

uint256 _exchangeOracleFee = (fundAmount *

exchangeOracleFeePercentage) / 100;

IERC20 tokenContract = IERC20(token);

if (_remaining > 0) {

IERC20 tokenContract = IERC20(token);

tokenContract.safeTransfer(launcher, _remaining);

fundAmount = 0;

remainingFunds = 0;

reservedFunds = 0;

if (_reputationOracleFee > 0) {

tokenContract.safeTransfer(reputationOracle, _reputationOracleFee);

}

if (_recordingOracleFee > 0) {

tokenContract.safeTransfer(recordingOracle, _recordingOracleFee);

}

if (_exchangeOracleFee > 0) {

tokenContract.safeTransfer(exchangeOracle, _exchangeOracleFee);

}

if (

_reputationOracleFee > 0 ||

_recordingOracleFee > 0 ||

_exchangeOracleFee > 0

) {

address[] memory oracles = new address[](3);

uint256[] memory amounts = new uint256[](3);

oracles[0] = reputationOracle;

oracles[1] = recordingOracle;

oracles[2] = exchangeOracle;

amounts[0] = _reputationOracleFee;

amounts[1] = _recordingOracleFee;

amounts[2] = _exchangeOracleFee;

emit OracleFeeTransfer(oracles, amounts);

}

if (_remainingFunds > 0) {

tokenContract.safeTransfer(launcher, _remainingFunds);

if (_status == EscrowStatuses.ToCancel) {

emit CancellationRefund(_remaining);

emit CancellationRefund(_remainingFunds);

}

remainingFunds = 0;

reservedFunds = 0;

}

EscrowStatuses _status = status;

uint256 _remainingFunds = remainingFunds;

uint256 _reputationOracleFee = (fundAmount *

reputationOracleFeePercentage) / 100;

uint256 _recordingOracleFee = (fundAmount *

recordingOracleFeePercentage) / 100;

uint256 _exchangeOracleFee = (fundAmount *

exchangeOracleFeePercentage) / 100;

IERC20 tokenContract = IERC20(token);

fundAmount = 0;

remainingFunds = 0;

reservedFunds = 0;

address[] memory oracles = new address[](3);

uint256[] memory amounts = new uint256[](3);

oracles[0] = reputationOracle;

oracles[1] = recordingOracle;

oracles[2] = exchangeOracle;

amounts[0] = _reputationOracleFee;

amounts[1] = _recordingOracleFee;

amounts[2] = _exchangeOracleFee;

if (_reputationOracleFee > 0) {

tokenContract.safeTransfer(reputationOracle, _reputationOracleFee);

}

if (_recordingOracleFee > 0) {

tokenContract.safeTransfer(recordingOracle, _recordingOracleFee);

}

if (_exchangeOracleFee > 0) {

tokenContract.safeTransfer(exchangeOracle, _exchangeOracleFee);

}

emit OracleFeeTransfer(oracles, amounts);

if (_remainingFunds > 0) {

tokenContract.safeTransfer(launcher, _remainingFunds);

if (_status == EscrowStatuses.ToCancel) {

emit CancellationRefund(_remainingFunds);

}

}

portuu3 · 2026-05-14T13:39:14Z

-            reservedFunds = 0;
        }

        if (_status == EscrowStatuses.ToCancel) {


if no payout happened the oracles should not get any fee

…cle fee calculations in Escrow contract

flopez7 added 3 commits May 5, 2026 18:56

fix oracle fee calculations and related functions to Escrow

a5ea128

Merge branch 'develop' into flopez/oracle-fees

15bbdfc

Merge branch 'develop' into flopez/oracle-fees

34bd3ce

flopez7 requested a review from portuu3 May 13, 2026 09:06

flopez7 self-assigned this May 13, 2026

flopez7 added the WIP Work In Progress label May 13, 2026

Refactor transaction logic when OracleFeeTransfer is emitted before C…

f015bb8

…omplete/Cancel in the same transaction

vercel Bot temporarily deployed to Preview – human-app May 13, 2026 12:33 Inactive

vercel Bot temporarily deployed to Preview – staking-dashboard May 13, 2026 12:33 Inactive

vercel Bot temporarily deployed to Preview – human-dashboard-frontend May 13, 2026 12:33 Inactive

portuu3 requested changes May 13, 2026

View reviewed changes

Refactor getNetFundAmount to use totalFundedAmount from subgraph inst…

0042ec0

…ead of rpc

vercel Bot temporarily deployed to Preview – staking-dashboard May 13, 2026 13:38 Inactive

vercel Bot temporarily deployed to Preview – human-app May 13, 2026 13:38 Inactive

vercel Bot temporarily deployed to Preview – human-dashboard-frontend May 13, 2026 13:38 Inactive

Fix internal transaction details in handleCancellationRefund to use c…

c6ce0dc

…anceler address and event amount

vercel Bot temporarily deployed to Preview – staking-dashboard May 14, 2026 08:46 Inactive

vercel Bot temporarily deployed to Preview – human-dashboard-frontend May 14, 2026 08:46 Inactive

vercel Bot temporarily deployed to Preview – human-app May 14, 2026 08:46 Inactive

Add changeset file

c7d97cf

vercel Bot deployed to Preview – staking-dashboard May 14, 2026 08:56 View deployment

vercel Bot deployed to Preview – human-dashboard-frontend May 14, 2026 08:56 View deployment

vercel Bot deployed to Preview – human-app May 14, 2026 08:56 View deployment

portuu3 requested changes May 14, 2026

View reviewed changes

Enhance cancellation logic to check for reserved funds and update ora…

dbcf09b

…cle fee calculations in Escrow contract

vercel Bot deployed to Preview – human-dashboard-frontend May 15, 2026 10:41 View deployment

vercel Bot deployed to Preview – human-app May 15, 2026 10:42 View deployment

vercel Bot deployed to Preview – staking-dashboard May 15, 2026 10:42 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure oracle fees are paid independently#3899

Ensure oracle fees are paid independently#3899
flopez7 wants to merge 8 commits into
developfrom
flopez/oracle-fees

flopez7 commented May 13, 2026

Uh oh!

vercel Bot commented May 13, 2026 •

edited

Loading

Uh oh!

portuu3 May 13, 2026

Uh oh!

portuu3 May 14, 2026

Uh oh!

portuu3 May 14, 2026

Uh oh!

portuu3 May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

flopez7 commented May 13, 2026

Issue tracking

Context behind the change

How has this been tested?

Release plan

Potential risks; What to monitor; Rollback plan

Uh oh!

vercel Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

portuu3 May 13, 2026

Choose a reason for hiding this comment

Uh oh!

portuu3 May 14, 2026

Choose a reason for hiding this comment

Uh oh!

portuu3 May 14, 2026

Choose a reason for hiding this comment

Uh oh!

portuu3 May 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented May 13, 2026 •

edited

Loading