Add missing MathML tags for annotations. #183#331
Open
fred-wang wants to merge 1 commit intohtml5lib:masterfrom
Open
Add missing MathML tags for annotations. #183#331fred-wang wants to merge 1 commit intohtml5lib:masterfrom
fred-wang wants to merge 1 commit intohtml5lib:masterfrom
Conversation
Contributor
|
The sanitizer is built to make sure the output is safe regardless of what the input was. So in order to approve adding these, I need to feel confident that these are safe to add. There's this comment which you wrote that talks about the safety of adding these bits: However, I don't know anything about MathML and can't evaluate that, so I can't approve this. We'll need someone who understands this to yay/nay it preferably with some proof. I'll hunt around and see if I can find someone I know. |
Contributor
|
I can't find anyone. I'm going to nix this from the 1.0 milestone. |
Author
|
@willkg What's the plan on this? Did you ask @jruderman ? |
Contributor
|
@fred-wang I didn't find anyone, so I nixed it from the 1.0 milestone. After I got 1.0 out, I stepped off of this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New attempt, rebasing on top of master and restricting to annotations.
https://developer.mozilla.org/en-US/docs/Web/MathML/Element/semantics
https://www.w3.org/TR/MathML/chapter3.html#presm.semantics