Skip to content

Fix to issue #1033 as proposed by @dkeeney#1034

Open
fcr wants to merge 3 commits into
htm-community:masterfrom
fcr:reset
Open

Fix to issue #1033 as proposed by @dkeeney#1034
fcr wants to merge 3 commits into
htm-community:masterfrom
fcr:reset

Conversation

@fcr

@fcr fcr commented Feb 9, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@dkeeney dkeeney left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@dkeeney

dkeeney commented Feb 11, 2025

Copy link
Copy Markdown

I was able to clone and checkout the "reset" branch on windows. I then did a full build and confirmed that the both C++ and Python unit tests ran.

I then setup Ubuntu on VirtualBox and cloned. But the "reset" branch was not there.
It appears that you checked in the PR via your fcr repository which my virtual box environment cannot access.
So, rather than try to unscramble that I will try to create a new PR directly on htm-community/htm.core.

@dkeeney

dkeeney commented Feb 12, 2025

Copy link
Copy Markdown

I am getting a build error on Ubuntu. Nothing to do with this PR, but googletest is not getting installed correctly during the build. Looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants