Skip to content

Comments

Do not report 'Error when communicating with server' and similar errors triggered by user (browser) actions#46

Merged
TDannhauer merged 1 commit intohorde:FRAMEWORK_6_0from
amulet1:fix_js_xhr_abort
Feb 18, 2026
Merged

Do not report 'Error when communicating with server' and similar errors triggered by user (browser) actions#46
TDannhauer merged 1 commit intohorde:FRAMEWORK_6_0from
amulet1:fix_js_xhr_abort

Conversation

@amulet1
Copy link
Contributor

@amulet1 amulet1 commented Feb 18, 2026

Rework XHR handler:

  • Set 'aborted' flag in 'onabort' handler
  • Ignore real readyState=4 event
  • Simulate readyState=4 event in 'onloadend' handler [after 'aborted' state is captured]
  • Do not return success if request was aborted
  • Drop support for IE6

Disable error notification in HordeCore.onFailure handler for aborted requests.

… errors triggered by user (browser) actions

Rework XHR handler:
 * Set 'aborted' flag in 'onabort' handler
 * Ignore real readyState=4 event
 * Simulate readyState=4 event in 'onloadend' handler [after 'aborted' state is captured]
 * Do not return success if request was aborted
 * Drop support for IE6

Disable error notification in HordeCore.onFailure handler for aborted requests.
@amulet1
Copy link
Contributor Author

amulet1 commented Feb 18, 2026

@TDannhauer Please review/merge.

@TDannhauer TDannhauer merged commit 9b2e187 into horde:FRAMEWORK_6_0 Feb 18, 2026
0 of 4 checks passed
@amulet1 amulet1 deleted the fix_js_xhr_abort branch February 18, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants