Open
Conversation
Remove unnecessary comment line
Add new cascading driver and tests for it
yunosh
reviewed
Feb 20, 2018
| public function testTransparent() | ||
| { | ||
| //throw exception if no backend provides transparent | ||
| $this->setExpectedException(Horde_Auth_Exception::class); |
Member
There was a problem hiding this comment.
This make the Travis test fail on PHP 5.4.
yunosh
reviewed
Feb 20, 2018
| * @param array $params Required parameters: | ||
| * <pre> | ||
| * 'drivers' - array hash of (Horde_Auth_Base) The list of backend drivers. | ||
| * 'order' - a list of drivers indexes to define a default order. |
Member
There was a problem hiding this comment.
Why is 'order' necessary? Why not using the order of 'drivers'?
yunosh
reviewed
Feb 20, 2018
| * 'order' - a list of drivers indexes to define a default order. | ||
| * </pre> | ||
| * | ||
| * 'capabilities' - defines capabilities this driver |
Member
There was a problem hiding this comment.
This should be part of the parameters, right?
yunosh
reviewed
Feb 20, 2018
| public function getParams() //test function to see all arrays | ||
| { | ||
| return($this->_test); | ||
| } |
yunosh
reviewed
Feb 20, 2018
| $newPassword .= $characters[rand(0, $charactersLength - 1)]; | ||
| } | ||
| } | ||
| $credentials = array('password' => $newPassword); |
Member
There was a problem hiding this comment.
There already is Horde_Auth::genRandomPassword()
yunosh
reviewed
Feb 20, 2018
| public function exists($userId) | ||
| { | ||
| // rotate through all backends which have list capabddlity or exists capability - return true if any backend has this user, otherwise return false. | ||
| if (!$this->hasCapability('list') and !$this->hasCapability('exists')) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the Mock Driver from PR #1 and a reworked version of the Auth_Fallback driver originally rejected upstream. It's now the "Cascading" driver, able to aggregate multiple backends for transition scenarios or running a local admin account database along an ldap for normal users. Please review.
However, the yaml file looks wrong (re-activating authors deactivated by a recent commit). Possibly a merge victim...