Skip to content

fix: bash arithmetic exit code in Redis migration script #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexluong wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: bash arithmetic exit code in Redis migration script #834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions scripts/issue-680/migrate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ for DEPLOY_ID in "${DEPLOYMENT_IDS[@]}"; do
if [[ -n "$INSTALLATION_ID" ]]; then
target_key="${DEPLOY_ID}:outpost:installation_id"
echo "SET ${target_key} ${INSTALLATION_ID}" >> "$PIPE_FILE"
((CMD_COUNT++))
((++CMD_COUNT))
fi

# Migration status keys (HSET is idempotent)
Expand All @@ -173,7 +173,7 @@ for DEPLOY_ID in "${DEPLOYMENT_IDS[@]}"; do
hash_data="${MIGRATION_DATA[$old_key]}"
if [[ -n "$hash_data" ]]; then
echo "HSET ${new_key} ${hash_data}" >> "$PIPE_FILE"
((CMD_COUNT++))
((++CMD_COUNT))
fi
done
done
Expand All @@ -182,15 +182,15 @@ done
if $CLEANUP; then
if [[ -n "$INSTALLATION_ID" ]]; then
echo "DEL outpostrc" >> "$PIPE_FILE"
((CMD_COUNT++))
((++CMD_COUNT))
fi
for key in "${MIGRATION_KEYS[@]}"; do
echo "DEL ${key}" >> "$PIPE_FILE"
((CMD_COUNT++))
((++CMD_COUNT))
done
if [[ "$LOCK_EXISTS" == "1" ]]; then
echo "DEL .outpost:migration:lock" >> "$PIPE_FILE"
((CMD_COUNT++))
((++CMD_COUNT))
fi
fi

Expand Down
Loading