Fix analog joystik.#25
Open
WiseLord wants to merge 4 commits into
Open
Conversation
After commits 8d8b640 and e07a949, analogRead() returns values in the range 0..4095, since PushButton.cpp continues working in 0..1023. This causes incorrect (too big) thresholdNS and thresholdEW values and joystick doesn't work (stucks in one direction). Fixes issue hjd1964#24.
Most probably, this delay is usefull just when debugging. But in normal case it just prolongues SHC boot time (and first picture on the screen). Leave it only if debug is ON.
Remove useless delay before display initialization.
ESP32 has enough free pins to specify software SPI pinout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After commits 8d8b640 and e07a949, analogRead() returns values in the range 0..4095, since PushButton.cpp continues working in 0..1023.
This causes incorrect (too big) thresholdNS and thresholdEW values and joystick doesn't work (stucks in one direction).
Fixes issue #24.