Open
Conversation
The new hierarchy will look like this:
Tuple
|- Tuplef (Tuple of type float)
| `- Tuple2f, Tuple3f, Tuple4f
|- Tupled (Tuple of type double)
| `- Tuple2d, Tuple3d, Tuple4d
`- Tuplei (Tuple of type int)
`- Tuple2i, Tuple3i, Tuple4i
The tuples of type byte (Tuple3b, Tuple4b) will not participate in this
hierarchy since they do not currently implement any of its methods (add,
subtract, etc.), unless someone wishes to write these methods.
Make most of the TupleXX classes extend either Tupled, Tuplef, or Tuplei. This includes the addition of methods where necessary and the removal of several now-unnecessary clone methods (these are covered by Tuple's clone method).
Add serialVersionUID to Tuple, Tuplef, Tuplei, and Tupled. Also remove the "implements java.io.Serializable, Cloneable" declarations from the subclasses of Tuple, as this commit makes them redundant.
Specify the abstract method equals(T) in type Tuple.
Documented Tuple, Tupled, Tuplef, Tuplei and their methods.
Add both interpolate methods to Tupled and Tuplef, as well as epsilonEquals to Tupled. (For some reason, Tuplef subclasses don't have epsilonEquals, and I didn't bother to add them.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a hierarchy for Tuples in my fork. The hierarchy looks like this:
Tupleb is missing from this because the Tuple*b classes don't currently have many of the methods that other Tuples do. The upper-level classes in this hierarchy declare useful abstract methods, so that it is possible to write code like this:
This resolves #3.