Did a performance analysis of the search#1300
Merged
VisLab merged 3 commits intohed-standard:mainfrom Apr 7, 2026
Merged
Conversation
|
Claude code review could not run. The request to the Claude API failed (possible causes: billing limit reached, token expired, or service unavailable). Review this PR manually. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a benchmarking harness and generated reports to document and compare performance characteristics of HED search implementations (basic_search, QueryHandler, StringQueryHandler), and updates docs accordingly.
Changes:
- Expanded
docs/search_details.mdwith implementation comparisons plus benchmark tables and methodology. - Added benchmark runner (
benchmarks/search_benchmark.py) with synthetic/real-data generation (benchmarks/data_generator.py). - Added a reporting tool (
benchmarks/report.py) and checked in generated benchmark artifacts (markdown report + at least one PNG).
Reviewed changes
Copilot reviewed 5 out of 25 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/search_details.md | Adds a structured “search details” page with performance benchmarks and guidance. |
| benchmarks/search_benchmark.py | New benchmark harness for compilation, single-string, series, and sweep benchmarks. |
| benchmarks/data_generator.py | Generates synthetic HED strings and loads real BIDS data for benchmarking. |
| benchmarks/report.py | Generates summary tables, plots, and a markdown report from JSON benchmark outputs. |
| benchmarks/results/benchmark_20260407_103440_report.md | Generated benchmark report checked into the repo. |
| benchmarks/figures/benchmark_20260407_103440_compile_vs_search.png | Generated plot checked into the repo. |
Comments suppressed due to low confidence (1)
docs/search_details.md:159
- This claims benchmarks used HED 8.4.0, but
benchmarks/data_generator.pydefaults to schema version 8.3.0 andsearch_benchmark.pyinstantiatesDataGenerator()without overriding it. Either update the harness default to 8.4.0 or adjust the documentation to match the actual schema version used.
|
Claude code review could not run. The request to the Claude API failed (possible causes: billing limit reached, token expired, or service unavailable). Review this PR manually. |
|
Claude code review could not run. The request to the Claude API failed (possible causes: billing limit reached, token expired, or service unavailable). Review this PR manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.