Add support for enabling nested virtualization for the ebs builder#679
Open
wagnerm wants to merge 1 commit into
Open
Add support for enabling nested virtualization for the ebs builder#679wagnerm wants to merge 1 commit into
wagnerm wants to merge 1 commit into
Conversation
This enable the ebs builder to launch an instances with NestedVirtualization enabled. This updates the aws-sdk v2 code paths, and updates the ec2 sdk dependency to v1.307.0 which includes the new NestedVirtualization field. The NestedVirtualization was originally added in v1.288.0, but the most recent version seems best. There appear to be legacy v1 SDK code paths in builder/common/ that use the deprecated v1 SDK, which does not support the NestedVirtualization field. So these will raise an error when that option is used instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This enables the ebs builder to launch an instances with NestedVirtualization enabled.
This updates the aws-sdk v2 code paths, and updates the ec2 sdk dependency to v1.307.0 which includes the new NestedVirtualization field. The NestedVirtualization was originally added in v1.288.0, but the most recent version seems best if we have to upgrade anyways. I'm happy to split this into another PR if you'd like, or downgrade to v1.288.0.
There appear to be legacy v1 SDK code paths in
builder/common/that use the deprecated v1 SDK, which does not support the NestedVirtualization field. So these will raise an error when that option is used instead. I don't totally understand why this code paths still exist using the v1 SDK, but let me know if something needs to be changed.Resolved Issues
Closes #655
Rollback Plan
If a change needs to be reverted, we will roll out an update to the code within 7 days.
Changes to Security Controls
No