fix: remove "type": "module" from package.json#2
Merged
Conversation
The compiled output uses extensionless imports (e.g. export * from './address') which Node.js ESM cannot resolve. Since this package is consumed through Next.js/webpack bundlers that handle extensionless imports fine, removing "type": "module" is the correct fix. This also avoids the bin script needing a .cjs extension. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jontsai
force-pushed
the
fix/bin-cjs-rename
branch
from
5e2f0e1 to
7f30740
Compare
jontsai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"type": "module"frompackages/core/package.jsonexport * from './address') which Node.js ESM cannot resolve"type": "module"is unnecessary and breaks direct Node.js usagebin/htk.jsto.cjsTest plan
npm pack --dry-runshows no warnings🤖 Generated with Claude Code